Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heartbeats: Notify operator inactivity on failure #3800

Merged
merged 41 commits into from
May 15, 2024

Conversation

tomaszslabon
Copy link
Contributor

@tomaszslabon tomaszslabon commented Apr 8, 2024

#Refs: #3796.
This PR enables notifying of operator inactivity failure after multiple failed heartbeats.
The inactivity notification is executed after three consecutive heartbeat failures.
A heartbeat is considered as failed if there was an error during message signing execution or the number of active signers was below a certain threshold.
The operator inactivity notification is performed by inactivityClaimExecutor and is similar to the DKG result submission process.

@tomaszslabon tomaszslabon force-pushed the heartbeats-update branch 5 times, most recently from 237268a to a288f9f Compare April 25, 2024 16:33
Copy link
Member

@lukasz-zimnoch lukasz-zimnoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me 👌 Some last nitpick comments around naming:

pkg/tbtc/heartbeat.go Outdated Show resolved Hide resolved
pkg/tbtc/heartbeat.go Outdated Show resolved Hide resolved
pkg/tbtc/heartbeat.go Outdated Show resolved Hide resolved
pkg/tbtc/inactivity.go Outdated Show resolved Hide resolved
pkg/tbtc/inactivity.go Outdated Show resolved Hide resolved
@tomaszslabon tomaszslabon force-pushed the heartbeats-update branch 4 times, most recently from 70cba05 to 9372f63 Compare May 13, 2024 16:44
@tomaszslabon tomaszslabon marked this pull request as ready for review May 14, 2024 18:01
lukasz-zimnoch
lukasz-zimnoch previously approved these changes May 15, 2024
@lukasz-zimnoch lukasz-zimnoch merged commit 56755f6 into main May 15, 2024
29 checks passed
@lukasz-zimnoch lukasz-zimnoch deleted the heartbeats-update branch May 15, 2024 13:08
@lukasz-zimnoch lukasz-zimnoch added this to the v2.1.0 milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants